Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an initial contributor CoC #2767

Merged
merged 1 commit into from Feb 6, 2014
Merged

add an initial contributor CoC #2767

merged 1 commit into from Feb 6, 2014

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Feb 5, 2014

this is so everybody knows this project is LEGIT and that you--yes
YOU--are welcome to help us build this weird little thing.

<3 to @BanTiK for the idea and the draft

calling all collaborators:

@vitorgalvao @passcod @nanoxd @fanquake @leoj3n @rolandwalker @kevinSuttle

HELLO ALL YOU GOOD PEOPLE, 😀

This is just a doc that asserts the sort of stuff we already do.

Take a looksie and raise any issues you might have.

Maybe you want to know more of why to do this, here is a start:

http://www.ethics.org/resource/why-have-code-conduct

@nanoxd
Copy link
Contributor

nanoxd commented Feb 5, 2014

There are a few extra spaces scattered throughout the document. Other then that, I have no issues with it.

@rolandwalker
Copy link
Contributor

👍 on respect.

@kevinSuttle
Copy link

+1. Thanks @phinze!

@phinze
Copy link
Contributor Author

phinze commented Feb 5, 2014

123a149 now with less spaces!

@leoj3n
Copy link
Contributor

leoj3n commented Feb 5, 2014

Just returning from a day of Jury duty; serendipitous timing. This is a good disclaimer for a large project.

I checked out the CoC project pop up on my feed when it was first open sourced (days ago), and I questioned the file naming at that time. For the cask project, underscores and lowercase aren't consistent with f.ex CONTRIBUTING.md. I'm generally used to CAPS or these kinds of files.

@fanquake
Copy link
Contributor

fanquake commented Feb 6, 2014

👍

On Thursday, February 6, 2014, Joel Kuzmarski notifications@github.com
wrote:

Just returning from a day of Jury duty; serendipitous. This is a good
disclaimer for a large project.

I checked out the CoC project pop up on my feed when it was first open
sourced (days ago), and I questioned the template name at that time. For
the cask project, underscores and lowercase aren't consistent with f.ex
CONTRIBUTING.md. I'm generally used to CAPS or these kinds of files.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2767#issuecomment-34275407
.

@vitorgalvao
Copy link
Member

Big thumbs up on this. I agree with @leoj3n, however, and I’m just slightly thorn on the naming issue. Having a consistent name accross all projects is a big plus if anyone wants to programatically check which projects adhere to this. This is akin to having a LICENSE file — though not mandatory, and a lot of projects include licensing in the READMD.md, or sometimes at the top of the file itself (particularly on scripts), it does help.

Having said that, I’m personally more inclined to keeping consistent naming accross the project.

Other than that, as stated, I'm all for including this, in whatever form.

this is so everybody knows this project is LEGIT and that you--yes
YOU--are welcome to help us build this weird little thing.

<3 to @BanTiK for the idea and the draft
@phinze
Copy link
Contributor Author

phinze commented Feb 6, 2014

Agreed on consistent naming.

How about this?

244d29c renames file to CONDUCT.md

@vitorgalvao
Copy link
Member

Looks good.

@phinze
Copy link
Contributor Author

phinze commented Feb 6, 2014

cool - doing it! 🍞 📙 ⚓ 🎱 ⌚ 〰️ 🌊

phinze added a commit that referenced this pull request Feb 6, 2014
@phinze phinze merged commit 361ed8e into master Feb 6, 2014
@phinze phinze deleted the contributor-covenant branch February 6, 2014 17:35
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants