Report SHA-256 hash (instead of SHA-1) if checksum is missing. #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally missed this in Homebrew#2719.
| @@ -29,6 +29,6 @@ def _check_sums(path, sums) | |||
| has_sum = true | |||
| end | |||
| end | |||
| raise ChecksumMissingError.new("Checksum required. SHA1: '#{Digest::SHA1.file(path).hexdigest}'") unless has_sum | |||
| raise ChecksumMissingError.new("Checksum required. SHA-256: '#{Digest::SHA256.file(path).hexdigest}'") unless has_sum | |||
There was a problem hiding this comment.
how about a copy and paste ready error message with a quickfix:
Checksum required. add this line to the cask file:
sha256 '#{Digest::SHA256.file(path).hexdigest}'
|
this detailed message (with quickfix) should also go top the |
|
👍 |
rolandwalker
added a commit
that referenced
this pull request
Feb 9, 2014
Report SHA-256 hash (instead of SHA-1) if checksum is missing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally missed this in #2719. Since SHA-256 is the suggested default, the suggested hash if there's one missing should presumably also be SHA-256.
I've checked the repo more thoroughly, and this seems to be the only significant thing missing from #2719 (although a lot of tests are still SHA-1).