restrict visibility of Cask namespace in Formula #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoops lol. we have a reworking in-project visibility strategy now... |
we had collision issues with homebrew's 'cask' formula (for the emacs package manager project). this keeps the in-project and in-formula visibility of the version number via the old "namespaced global" strategy that keeps a `Cask` constant out of view of the formula.
|
there we go. ready for review 👌 |
|
👍 |
|
Ship it! |
phinze
added a commit
that referenced
this pull request
Feb 10, 2014
restrict visibility of Cask namespace in Formula
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had collision issues with homebrew's 'cask' formula (for the emacs
package manager project).
this keeps the in-project and in-formula visibility of the version
number via a different strategy that keeps a
Caskconstant out of viewof the formula.
alternate strategy to #2832