Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken brew cask alfred link #3275

Merged
merged 1 commit into from Feb 28, 2014
Merged

Fix broken brew cask alfred link #3275

merged 1 commit into from Feb 28, 2014

Conversation

mecca831
Copy link
Contributor

brew cask alfred link is broken because features.defaultresults.scope is a string instead of a dictionary:

[00:13]:) ~ $ brew cask alfred link
==> Successfully linked Alfred to homebrew-cask.
[00:13]:) ~ $ brew cask alfred status
==> Alfred is not linked to homebrew-cask.
[00:15]:) ~ $ defaults read com.runningwithcrayons.Alfred-Preferences
{
    NSNavLastRootDirectory = "~/Documents";
    NSNavPanelExpandedSizeForOpenMode = "{750, 480}";
    "NSWindow Frame alfredpreferences" = "0 56 1383 822 0 0 1440 878 ";
    "features.defaultresults.scope" = "('/Applications','/Applications/Xcode.app/Contents/Applications','/Developer/Applications','/Library/PreferencePanes','/System/Library/PreferencePanes','~/Library/Caches/Metadata/','~/Library/Mobile Documents/','~/Library/PreferencePanes','/opt/homebrew-cask/Caskroom')";
    lastTab = features;
    lastTabBuild = 227;
    lastTabTS = "415265223.980409";
    version = "2.1.1";
}
  • Remove quotes from defaults write args. With quotes the value is
    written as a string instead of a dictionary, which breaks the search
    scope in alfred.
  • Make the default scope consistent with alfred default

- Remove quotes from `defaults write` args. With quotes the value is
  written as a string instead of a dictionary, which breaks the search
  scope in alfred.
- Make the default scope consistent with alfred default
@rolandwalker
Copy link
Contributor

Thanks!

This seems to have been broken since #2624 (release 0.29.0). And the tests didn't catch it because the tests were wrong. Apologies if the bug caused you any inconvenience.

rolandwalker added a commit that referenced this pull request Feb 28, 2014
Fix broken `brew cask alfred link`
@rolandwalker rolandwalker merged commit 9979d9c into Homebrew:master Feb 28, 2014
@mecca831 mecca831 deleted the alfredFix branch February 28, 2014 18:07
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants