Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to homebrew's move of the tap directory #4042

Merged
merged 1 commit into from Apr 26, 2014

Conversation

rolandwalker
Copy link
Contributor

WORK IN PROGRESS, still fails 6 tests. References #4035, #4029, #4026

I can't work on this further til tomorrow. If anyone wants to address the test failures that would be most welcome.

Completed

@alebcay
Copy link
Member

alebcay commented Apr 25, 2014

[  55/1625] Cask::CLI#test_0001_lists the taps for casks that show up in two taps = 0.01 s                  
  1) Failure:
Cask::CLI#test_0001_lists the taps for casks that show up in two taps [/Volumes/MacData/homebrew/homebrew-cask/test/cask/cli_test.rb:9]:
--- expected
+++ actual
@@ -1 +1 @@
-["google-chrome", "passcod/cask/adium", "phinze/cask/adium"]
+["google-chrome", "passcod/homebrew-cask/adium", "phinze/cask/adium"]

It appears that the only discrepancy on this test is that passcod/homebrew-cask/adium is not shortened into passcod/cask/adium. Not sure why.

@gsong
Copy link
Contributor

gsong commented Apr 25, 2014

@alebcay Fixed with rolandwalker#2

@alebcay
Copy link
Member

alebcay commented Apr 26, 2014

@gsong Other tests are still failing:

❯ bundle exec rake test
Run options: 

# Running tests:

[  75/1625] Cask::CLI::Create#test_0004_raises an exception when the cask already exists = 0.05 s           
  1) Failure:
Cask::CLI::Create#test_0004_raises an exception when the cask already exists [/Volumes/MacData/homebrew/homebrew-cask/test/cask/cli/create_test.rb:60]:
CaskAlreadyCreatedError expected but nothing was raised.

[  80/1625] Cask::CLI::Edit#test_0001_opens the editor for the specified cask = 0.02 s                      
  2) Error:
Cask::CLI::Edit#test_0001_opens the editor for the specified cask:
CaskUnavailableError: No available cask for alfred, use `brew cask create alfred` to make a new cask with this name
    /Volumes/MacData/homebrew/homebrew-cask/lib/cask/cli/edit.rb:8:in `run'
    /Volumes/MacData/homebrew/homebrew-cask/test/cask/cli/edit_test.rb:27:in `block (2 levels) in <top (required)>'

[  81/1625] Cask::CLI::Edit#test_0002_throws away additional arguments and uses the first = 0.03 s
  3) Error:
Cask::CLI::Edit#test_0002_throws away additional arguments and uses the first:
CaskUnavailableError: No available cask for adium, use `brew cask create adium` to make a new cask with this name
    /Volumes/MacData/homebrew/homebrew-cask/lib/cask/cli/edit.rb:8:in `run'
    /Volumes/MacData/homebrew/homebrew-cask/test/cask/cli/edit_test.rb:34:in `block (2 levels) in <top (required)>'

[ 108/1625] Cask::CLI::Search#test_0008_does not search the Tap name = 0.02 s                               
  4) Failure:
Cask::CLI::Search#test_0008_does not search the Tap name [/Volumes/MacData/homebrew/homebrew-cask/test/cask/cli/search_test.rb:71]:
Expected /^No cask found for "phinze"\.\n/ to match "==> Partial matches\nphinze/homebrew-cask/caffeine\nphinze/homebrew-testcasks/caffeine\n".

Finished tests in 47.305110s, 34.3515 tests/s, 98.0232 assertions/s.                                        
1625 tests, 4637 assertions, 2 failures, 2 errors, 4 skips

ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-darwin12.0]
rake aborted!
Command failed with status (4): [ruby -I"lib:test" -I"/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib" "/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" ]
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/testtask.rb:104:in `block (3 levels) in define'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils.rb:45:in `call'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils.rb:45:in `sh'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils_ext.rb:37:in `sh'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils.rb:82:in `ruby'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils_ext.rb:37:in `ruby'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/testtask.rb:100:in `block (2 levels) in define'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/file_utils_ext.rb:58:in `verbose'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/testtask.rb:98:in `block in define'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:246:in `call'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:246:in `block in execute'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:241:in `each'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:241:in `execute'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:184:in `block in invoke_with_call_chain'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:177:in `invoke_with_call_chain'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/task.rb:170:in `invoke'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:143:in `invoke_task'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:101:in `block (2 levels) in top_level'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:101:in `each'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:101:in `block in top_level'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:110:in `run_with_threads'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:95:in `top_level'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:73:in `block in run'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:160:in `standard_exception_handling'
/Library/Ruby/Gems/1.8/gems/rake-10.0.4/lib/rake/application.rb:70:in `run'
Tasks: TOP => test
(See full trace by running task with --trace)

@rolandwalker
Copy link
Contributor Author

@alebcay that's an intentional test failure -- the test string showed the desired output.

I've updated the PR. The remaining failures have to do with the test suite itself (I think).

rolandwalker added a commit that referenced this pull request Apr 26, 2014
Adapt to homebrew's move of the tap directory
@rolandwalker rolandwalker merged commit f7a209d into Homebrew:master Apr 26, 2014
@rolandwalker
Copy link
Contributor Author

There's a new code release -- brew update && brew upgrade brew-cask should fix the problem.

@rolandwalker rolandwalker deleted the tap_location_change branch April 26, 2014 21:49
rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this pull request May 8, 2014
This test used to selectively fail only on Travis.  The problem
was never isolated.  However, it was apparently recently fixed,
probably in Homebrew#4042.
gaishimo pushed a commit to gaishimo/homebrew-cask that referenced this pull request May 16, 2014
This test used to selectively fail only on Travis.  The problem
was never isolated.  However, it was apparently recently fixed,
probably in Homebrew#4042.
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants