-
Notifications
You must be signed in to change notification settings - Fork 250
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with actions/checkout@v2 #10
Comments
nice find. |
maybe skip the first part if on a detached HEAD? not sure that whole section is needed on v2. Something like this |
Just wanted to note that I was having trouble getting this action to work but saw @ahaverbuch note here about v1 vs v2 and that helped me. Thanks for opening the issue! This saved me lots of time debugging. |
V2 support is quite crucial. |
Most other actions nowadays don't support checkout v1, making this lib incompatible and impossible to integrate in many workflows. Is there any workaround for using this with v2? |
ok, I finally had time to fix that :) |
Thanks for a useful action!
We noticed this in one of our projects; https://github.com/actions/checkout is called before phips28/gh-action-bump-version, and that worked great in actions/checkout@v1 of it.
In actions/checkout@v2, they changed to no longer use a detached HEAD at first, instead to use a branch directly; this causes gh-action-bump-version to fail.
Appears this is because gh-action-bump-version is trying to make the same commit twice (once on the initial branch, and once when checking out the second branch) - as those are now the same. (error line is here: https://github.com/phips28/gh-action-bump-version/blob/v5.0.19/index.js#L55 )
We got the same error @benitazhang mentioned here be1eb84#commitcomment-36934730 - failing when running
git commit -a -m ci: version bump to [version]
(it is not related to the quotes change though, as that change works fine with actions/checkout@v1 - thanks for fixing that!)
The text was updated successfully, but these errors were encountered: