Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45 adapt to Redmine 4.0 #48

Closed
wants to merge 2 commits into from

Conversation

Dkstu
Copy link

@Dkstu Dkstu commented May 23, 2019

adapt to Redmine 4.0,

I don’t know rails, but I tried to support it with redmine 4.0. Please help confirm these changes.

@octoquad
Copy link

@Dkstu, I just upgraded to Redmine 4.0.3 from 3.4.6 and can confirm this patch works. Just on line 22 and 24, render(:plain => ... needs to be used instead of render(:text ... to fix a 500 Internal error

Completed 500 Internal Server Error in 1566ms (ActiveRecord: 0.7ms)
  
ActionView::MissingTemplate (Missing template gitlab_hook/index with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :rsb]}. Searched in:
  * "/home/redmine/redmine/plugins/redmine_gitlab_hook/app/views"
):

Environment:
Redmine version 4.0.3.stable
Ruby version 2.5.5-p157 (2019-03-15) [x86_64-linux]
Rails version 5.2.3

@Dkstu
Copy link
Author

Dkstu commented Jun 10, 2019

@octoquad thanks for your feedback, i fixed it

@phlegx
Copy link
Owner

phlegx commented Jun 17, 2019

Hi @Dkstu! Thank you for the PR. Are this changes :text => :plain backward compatible?

@phlegx phlegx closed this Jun 18, 2019
@Dkstu
Copy link
Author

Dkstu commented Jun 19, 2019

Hi @phlegx
I don’t know rails, so i can't unconfirmed.

@phlegx
Copy link
Owner

phlegx commented Jun 19, 2019

@Dkstu some of your changes are in the new release 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants