You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On phlex-rails main, if a request includes the turbo-frame header, and the rails app renders a Phlex view that renders the turbo frame using turbo_frame_tag output helper, nothing is rendered. This is from the behavior introduced in #154. The issue is because Phlex doesn't render the <turbo-frame> element, it doesn't know about the fragment. Possible solutions include grabbing the id positional arg and putting it in the context.fragments? Same applies for other output helpers that could have an id.
The text was updated successfully, but these errors were encountered:
Another issue that seems related, if you render a component before the fragment, and that component takes advantage of the fact you can just return a string in the block, then that string is still output in the response. I added this commit https://github.com/davekaro/test-phlex/commit/b7171133e21b37f8b0fd25578b4b4b6980dd9f9c that demonstrates this.
Fixes the issue described
phlex-ruby/phlex-rails#174 (comment)
I was seeing text output before a `<turbo-frame>` in my responses, and
it was all from components that render the text "implicitly".
I found no performance difference with these changes.
On phlex-rails main, if a request includes the turbo-frame header, and the rails app renders a Phlex view that renders the turbo frame using
turbo_frame_tag
output helper, nothing is rendered. This is from the behavior introduced in #154. The issue is because Phlex doesn't render the<turbo-frame>
element, it doesn't know about the fragment. Possible solutions include grabbing theid
positional arg and putting it in the context.fragments? Same applies for other output helpers that could have anid
.The text was updated successfully, but these errors were encountered: