Phlex::SVG

[davekaro]

Following up on #492. Mostly adding the remaining SVG tags. Still needs more tests and work.

SVG element list available https://www.w3.org/TR/SVG2/eltindex.html

Example

class Icon < Phlex::SVG
  def template
    svg("viewBox" => "0 0 100 100" xmlns: "http://www.w3.org/2000/svg") do
      path(d: "M 10,30
        A 20,20 0,0,1 50,30
        A 20,20 0,0,1 90,30
        Q 90,60 50,90
        Q 10,60 10,30 z"
      )
    end
  end
end

The SVG tags g and path are being removed from Phlex::HTML as they were a bit of a hack, but the svg tag now yields a new Phlex::SVG which can be used inline.

class Icon < Phlex::HTML
  def template
    svg("viewBox" => "0 0 100 100" xmlns: "http://www.w3.org/2000/svg") do |s|
      s.path(d: "M 10,30
        A 20,20 0,0,1 50,30
        A 20,20 0,0,1 90,30
        Q 90,60 50,90
        Q 10,60 10,30 z"
      )
    }
  end
end

[joeldrapper]

This is looking really great. I will follow up with a closer review soon.

[joeldrapper]

Can we rename this SGML? https://en.wikipedia.org/wiki/Standard_Generalized_Markup_Language

[marcoroth]

I feel like SGML is weird, because no one knows this by heart. Also Nokogiri uses XML throughout their lib for representing XML and HTML nodes.

Or otherwise, also provide a XML < SGML class 🤔

[davekaro]

Users of Phlex probably don't need to know about the SGML class, right? I think SGML makes sense, and could see a future Phlex::XML to generate strict XML.

[joeldrapper]

Yes, I would like to have a Phlex::XML class for working with strict XML with support for namespaces.

[marcoroth]

Fair enough 👍🏼

[joeldrapper]

I think this could do with a fair amount of refactoring, but it's a huge PR and it works and I’d like to merge it sooner rather than later so it doesn't get out of sync with other work.