Apply consistent symbol/string attribute transformation for Hash values #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbol attribute keys are dasherized before rendering, whereas string
keys are passed through verbatim.
However if the value is a Hash, the dasherize transform will not be
applied to the key even if it is a symbol. This change makes it so the
dasherization is applied even in this case.
```rb
a(data_turbo: { method: "post", confirm: "Are you sure?" })
```
Should render
```html
<a data-turbo-method="post" data-turbo-confirm="Are you sure?"></a>
```
willcosgrove
force-pushed
the
dasherize-symbol-hash-attributes
branch
from
5d3b221
to
bd65bd5
Compare
joeldrapper
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol attribute keys are dasherized before rendering, whereas string keys are passed through verbatim.
However if the value is a Hash, the dasherize transform will not be applied to the key even if it is a symbol. This change makes it so the dasherization is applied even in this case.
Should render