Improve performance by using bytesize when comparing if the string changed #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
length
slows down as the string grows (appears to be O(n)).bytesize
stays the same O(1). Even on very small strings like"<h1>"
,bytesize
is much faster thanlength
. By swapping over tobytesize
we can see an overall improvement in Phlex bench.rb:Before (using length):
After (using bytesize):
If we further tune
bench.rb
as I've done in this PR to more accurately represent what might be a typical "string length" when using Phlex (think larger components or full page views), we see an even more dramatic improvement:Before (using length on larger string):
After (using bytesize on larger string):
Comes to about a 7x speed increase. Always faster, with potential for huge gains. I had a page go from 15 seconds to 300ms with this change (50x speedup). This was a rare page of over 3 megabytes of HTML all generated by Phlex, but still pretty fun.