This repository has been archived by the owner on Jan 23, 2019. It is now read-only.
Setting empty password causes exception... #93
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an empty password for a pg_user causes an exception.
Bug
For pg_user.rb, the role_sql variable in Line 17 gets << a nil when there is no password and it throws an exception as it cannot implicitly convert nil into a string. My fix is to else an empty string.
Usage case
My usage case for no password. I configure a development systems and I want to create pg_user with the same name as a login. This gives my login user pg permissions, mainly CREATEDB, which is very useful to a rails developer.
Reproducing Error
Reproduce this in test-kitchen by converging with the following yml added.