Allows the page_size value to be passed in the request. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a frequent requirement that API clients can indicate the number of results that they require, rather than the API providing a fixed number of results. This change allows resources to specify a page_size_parameter which is used to indicate the name of a query parameter which indicates the number of results to return. * The default behaviour remains unchanged. * Allows each resource to specify the page_size_parameter, which is handled by the factory and assigned to the controller. * Adds a pageSizeParameter to the ResourceController, which is used to extract a query parameter from the request; if not provided, the pageSize is used instead.
|
Build failures appear to be unrelated to the pull request. |
|
@weierophinney is there anything that you need me to tidy up on this? |
weierophinney
added a commit
that referenced
this pull request
Jul 23, 2013
Allows the page_size value to be passed in the request.
weierophinney
added a commit
that referenced
this pull request
Jul 23, 2013
- Added test showing that page size parameter can be passed, and will be honored.
weierophinney
added a commit
that referenced
this pull request
Jul 23, 2013
|
Thanks @weierophinney, that's great. I'm happy to provide unit tests on any further reuests, just refuse to merge until I stump up ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a frequent requirement that API clients can indicate the number of results that they require, rather than the API providing a fixed number of results.
This change allows resources to specify a page_size_parameter which is used to indicate the name of a query parameter which indicates the number of results to return.