Check github URLs for existing pull request links #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
Check github URLs for existing pull request links
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
Forward port #22 Conflicts: CHANGELOG.md
|
Thanks, @DASPRiD! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces actual checking of generated pull request links for their existence. If it encounters a redirect, it will probe the given Location as well.
This PR follows the original behaviour of first checking a possibly provided package name. If a PR with that package name does not exist, the script bails out immediately. Next it will probe a link generated from the composer package name. If that one fails as well, it will resort to trying out all remote URLs supplied by git. If everything fails, an exception will be thrown.