Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polar graph support #62

Closed
ryananeff opened this issue Sep 18, 2018 · 6 comments
Closed

Add polar graph support #62

ryananeff opened this issue Sep 18, 2018 · 6 comments

Comments

@ryananeff
Copy link
Contributor

Currently I am working with a polar scatter plot and would appreciate label adjustment!

@Phlya
Copy link
Owner

Phlya commented Sep 18, 2018

Hi, I think it should work with polar plots, can you show an example where it doesn't?

@ryananeff
Copy link
Contributor Author

Here is a test example https://gist.github.com/nosarcasm/452ec450482a3f2761215640f1f86654

Maybe it doesn't know it is in polar mode?

@Phlya
Copy link
Owner

Phlya commented Sep 18, 2018

Right, I see, thanks. I guess it means it doesn't actually work with polar plots - I never properly tested it... Sorry, this would require a bit of work, and I am quite busy at the moment, don't know when I will find the time.
Looks like the autoalignment works though, that's something...

@ryananeff
Copy link
Contributor Author

What would such a fix entail? Wondering if this is just something that can be fixed by converting to cartesian coordinates before layout and then converting back or something worse...

@Phlya
Copy link
Owner

Phlya commented Sep 18, 2018

I am starting to think the best and most general way to deal with this would be to perform all operations on Axes coordinates instead of Data coordinates. This way there shouldn't be any issues with unusual axes coordinates or coordinate systems. In theory it should be enough to change the transforms across the code, but these things are never as simple as one imagines... I'd be delighted if you wanted to give this a go, of course!

@ryananeff
Copy link
Contributor Author

I switched all coordinates over to display coordinates (which are pixels), seems to work well. FYI, you may find that the precision/expansion values in the Examples.ipynb may need to be tweaked now.

@Phlya Phlya closed this as completed in c4cd0bd Jun 23, 2020
Phlya added a commit that referenced this issue Jun 23, 2020
Fix #62 Added polar graph support
And should work with any axes in general?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants