FormatCommand.formatGenerated allows ignoring generated files (.g.dart) #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
passsy
commented
Feb 6, 2023
passsy
commented
nohli
reviewed
Feb 6, 2023
| @@ -96,17 +103,18 @@ class FormatCommand extends Command { | |||
|
|
|||
| final allFiles = | |||
| SidekickContext.projectRoot.findFilesToFormat(globExcludes).toList(); | |||
| final withoutGenerated = filterGeneratedFiles(allFiles).toList(); | |||
There was a problem hiding this comment.
Is this filename still correct?
If formatGenerated is true, this includes all files.
There was a problem hiding this comment.
Any better idea than maybeWithithOrWithoutGeneratedFiles?
Giuspepe
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
LGTM but I think we can do this with much less code
final bool formatGenerated;
FormatCommand({
List<String> excludeGlob = const [],
this.defaultLineLength = 80,
this.formatGenerated = true,
}) : this.excludeGlob = [
...excludeGlob,
if (!formatGenerated) ...['**.freezed.dart', '**.g.dart'],
] {
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.