Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay the JSMpeg.CreateVideoElements call 'till after the script has loaded #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skerit
Copy link

@skerit skerit commented Sep 20, 2017

I couldn't find an issue about it, so I guess nobody has come across this issue yet.

When you load JSMpeg on-the-fly, it performs a JSMpeg.CreateVideoElements(); call because document.readyState === 'complete'

That's nice and all, but it does that before all the other code has run, so JSMpeg.Player and all is still null.

Wrapping it in a simple setTimeout fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant