feat: add output to step summary #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this critical bug of this otherwise great action! Used both options and they worked as expected. |
|
Can we merge please? We could use this |
You can use it in your workflow already like this: |
This was referenced Nov 8, 2022
|
Checked this out. Works well:
It's also worth noting unlike with separate reports, updating the workflow summary doesn't need write access to the repo, and thus will also work if you open a PR from a fork, like here. |
|
Great improvement @jcdickinson! |
ddl-ebrown
added a commit
to dominodatalab/datareader
that referenced
this pull request
May 26, 2024
- NOTE: the report step will not always be attached to the test workflow - it may be attached to golangci-lint see: dorny/test-reporter#67 https://github.com/orgs/community/discussions/24616 a fork of this dorny/test-reporter has a solution at: phoenix-actions/test-reporting#21
ddl-ebrown
added a commit
to dominodatalab/datareader
that referenced
this pull request
May 26, 2024
- Since we don't yet have SDLC pipeline projects for Go libraries or
for public projects, add in some limited CI validation for PRs to
this repo including:
* A build and test stage that generates binaries with the Makefile
*and* runs make test-coverage to produce coverage (not currently
used in CI)
Also uploads these as artifacts
* Linting through the golangci-lint Github Action
- NOTE: intially use dorny/test-reporter which produces Github checks,
which by design doesn't always attach to the right workflow - results
may show up with golangci-lint. See
dorny/test-reporter#67
https://github.com/orgs/community/discussions/24616
To resolve this, switch to a fork that uses summary instead:
phoenix-actions/test-reporting#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows adds the option
output-to, which can be set tostep-summary(orchecks). This circumvents the issue mentioned in the README under "Github limitations"