changing is_international? method to more semantic meaning, like shou…

…ld_checkout_with_fastspring? to eliminate ambiguity with the logic seperating the 2 concerns

README.md

@@ -20,9 +20,9 @@ Or install it yourself as:
 
 the PaymentMethod::Fastspring configurable should be directly available in spree admin payment methods.  Be sure to set up your gateway.
 
-Also, be sure in your user model (where current_user reads from) to add an "is_international?" logic block like follows:
+Also, be sure in your user model (where current_user reads from) to add an "should_checkout_with_fastspring?" logic block like follows:
 
-def is_international?
+def should_checkout_with_fastspring?
 	return true
 end
 

app/controllers/spree/orders_controller_decorator.rb

@@ -1,9 +1,9 @@
 module Spree
   OrdersController.class_eval do
-    before_filter :check_for_international, only: :edit
+    before_filter :allow_fastspring, only: :edit
 
-    def check_for_international
-      @international = true if current_user && current_user.is_international?
+    def allow_fastspring
+      @use_fastspring = true if current_user && current_user.should_checkout_with_fastspring?
     end
 
     def fastspring_complete

app/views/spree/orders/edit.html.erb

@@ -10,7 +10,7 @@
 
 <% else %>
   <div data-hook="outside_cart_form">
-    <%= form_for @order, :url => (@international ? PaymentMethod::Fastspring.product_add_url : update_cart_path), :html => {:id => 'update-cart'} do |order_form| %>
+    <%= form_for @order, :url => (@use_fastspring ? PaymentMethod::Fastspring.product_add_url : update_cart_path), :html => {:id => 'update-cart'} do |order_form| %>
       <div data-hook="inside_cart_form">
 
         <div data-hook="cart_items">
@@ -25,7 +25,7 @@
 					<%= button_tag :class => 'primary', :id => 'update-button' do %>
             <%= t(:update) %>
           <% end %>
-					<% if @international %>
+					<% if @use_fastspring %>
 							<input type="hidden" name="operation" value="create"/>
 							<input type="hidden" name="destination" value="contents"/>
 							<input type="hidden" name="mode" value="test" />