limit the growth of the training record PDF #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new service method to list trials of courses, that a particular employee attended - to limit the size by excluding trials that already have been archived, the selected trial status types get a "relevant_for_courses" column - renderTrainingRecordPDF becomes additional parameters: - allTrials y/n: render PDF for all trials ever (including the archived ones), or only the ones with relevant_for_courses status - trialIds: explicitly specify the trial ids to include in the training record (might me a single one only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Training Record pdf added 2020 renders a cumulative list of an employee's attended trainings.
it will therefor grow over time, but usually trials which have been eg. "archived" are no longer of interest.
to adress this situation, the possibility to narrow training records to only "active" trials, or even a particular trial will be added.