Generate URL safe tokens from Phoenix.Token

[chrismccord]

No description provided.

[josevalim]

We should fix this in Plug. :)

[jeregrine]

And or maybe add a new fn to URI   

—
Sent from Mailbox

On Wed, Oct 7, 2015 at 6:22 PM, José Valim notifications@github.com
wrote:

We should fix this in Plug. :)

Reply to this email directly or view it on GitHub:
#1257 (comment)

[josevalim]

Elixir is fine, it has everything we need. We just need to use url_encode64/url_decode64 in Plug.

[scrogson]

Handling this in Plug will break backwards compatibility. I know there are a few people using Plug's crypto stuff to be able to share cookies with Rails apps.

Since the tokens generated from Plug are generally used in cookies, it feels slightly out of place for Plug, IMHO.

[josevalim]

We can easily maintain compatibility with Plug by using Base.url_decode64 and falling back to Base.decode64. Any reason why this wouldn't work?

[scrogson]

@josevalim ok, that sounds good. 👍

[scrogson]

I'll take care of this in Plug.

[chrismccord]

ping @scrogson . how are we coming on this one?

[scrogson]

PR posted here: elixir-plug/plug#309