Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier dev error page #281

Closed
chrismccord opened this issue Aug 20, 2014 · 11 comments
Closed

Add prettier dev error page #281

chrismccord opened this issue Aug 20, 2014 · 11 comments
Milestone

Comments

@chrismccord
Copy link
Member

Possibly borrow Dynamo's

@chrismccord chrismccord changed the title Add prettier error page Add prettier dev error page Aug 20, 2014
@slogsdon
Copy link
Contributor

slogsdon commented Sep 3, 2014

I'd like to contribute something for this if no one's started yet.

I like Dynamo's dev error screen, but personally, I would want a bit more information for debug purposes, maybe something similar to this. Thoughts?

@josevalim
Copy link
Member

I like Dynamo's functionality of navigating stacktraces, we should definitely work on its functionalities though. I think we should add most of this directly to Plug.

@chrismccord
Copy link
Member Author

@slogson we'd love help. @josevalim, how do you see this being implemented in Plug wrt to file serving/assets? It would be very easy to get in place in Phoenix since we can just render a Phoenix eex template right in the Phoenix ErrorController, i.e. https://github.com/phoenixframework/phoenix/blob/master/lib/phoenix/controller/error_controller.ex#L37

Instead of that placeholder html, we would just render an error_debug.html.eex template with the pretty error stacktraces.

@josevalim
Copy link
Member

It will be just a plug. We don't need to worry about assets in the error page as we can always embed them in the html.

@chrismccord
Copy link
Member Author

It will be just a plug. We don't need to worry about assets in the error page as we can always embed them in the html.

👍 we can just call it from the error_debug action. @slogsdon if you want to put together a PR for plug I'll leave this open until we have things in place on the Plug side

@chrismccord
Copy link
Member Author

@slogsdon Have you started on this yet? @gjaldon this would be a good one to tackle if it's still up for grabs.

@gjaldon
Copy link
Contributor

gjaldon commented Sep 17, 2014

@chrismccord cool! I'd gladly work on this if it is still available! Just to clarify, this will be done in Plug and then add it to the plug stack in Pheonix?

@chrismccord
Copy link
Member Author

Just to clarify, this will be done in Plug and then add it to the plug stack in Pheonix?

Yes, exactly. Let's wait to see where @slogsdon is at. Otherwise, it's all yours!

@slogsdon
Copy link
Contributor

I've started, but I haven't gotten far, to be honest. @gjaldon feel free to pick this up if you're wanting to do so.

@gjaldon
Copy link
Contributor

gjaldon commented Sep 18, 2014

@slogsdon, great! I'll be taking this on then. 👍

@josevalim
Copy link
Member

I am working on this and it will be pushed soon.

Gazler pushed a commit to Gazler/phoenix that referenced this issue Sep 17, 2015
Add nginx upgrade headers to prevent cutting connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants