-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info about running endpoints wrong #3149
Comments
Looks like it might have been introduced in #3105 ? |
What would the expected behavior be if the config looked like the following?
It seems like it could go a few different ways:
Or
|
That is what is addressed in #3105 I believe, so the output should be (in my view)
|
Ah I see the issue now. Let's go with the "replace one" approach, where the configured URL scheme wins, so:
from your config. Thanks! |
I have a PR to make it match @chrismccord's example. #3152 I'm not sure if this is the right way to go though, it seems a bit confusing not to know the port you're actually bound too. I wonder if it would be better to always use the hostname from |
Wouldn't it be better to explicitly state the configured url next to the endpoint's bound ip/port? Maybe for example showing |
This PR would match @benperiton's example above. #3158 |
Maybe the configured URL should be displayed completely separate from the listeners and we should just display what's bound here. For example:
|
@sionide21 that would be even clearer indeed IMO 👍 (I really like that the information needed to grasp what is going on regarding listening and url configuration is made visible) |
@sionide21 Yea, that looks pretty good - all the info is right there |
@sionide21 that is a great idea! I would only s/Serving/Access and we are good to go! |
@chrismccord How does #3160 look? |
Environment
Expected behavior
Using this config:
It should show the correct ports for the endpoints that are running:
Actual behavior
The text was updated successfully, but these errors were encountered: