-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a phoenix-static buildpack #835
Comments
A new Heroku CLI feature that should help with this will land today or tomorrow. I'll update when it is. |
Tell us more! 🙊 |
I personally think using a multi-buildpack approach is better. The advantages are among other things:
I've been thinking about writing a guide on how to do this, but a sooper quick rundown is:
I'm using this for patback (very WIP project), and it works like a charm. |
You'll be able to do it without using that buildpack very soon. |
The buildpack stuff has been released if you update your client. They are still working on a devcenter article:
|
Awesome!! 😄 👍 |
As there's a few gotchas (e.g. multiple buildpacks and asset digesting), would it be good to add a "Deploying to Heroku" section to the official Phoenix guides? This would an alternative to creating a phoenix static buildpack. |
We don't need a separate buildpack - just a post_compile hook in the existing buildpack, with that it should be fairly straight forward process of setting it up. Either way documenting it in the guides is a good idea. |
Revamping the way we handle deployment in the guides is coming up right after the current chunk of work on testing. Right now, we have this tabula rasa for Heroku deployment: As always, PR's are very welcome. :) |
@lancehalvorsen I will contribute docs when the buildpack is ready. |
@ericmj, for that, you get the @josevalim -style-all-the-hearts-emoji! |
Hi all! Just created a phoenix static buildpack. It has configuration much like elixir buildpack. It caches node, npm modules and bower components and runs I tried it out with several Heroku deploys and it seems to work fine. I also had @ericmj initially review it. I'll address any issues reported as soon as I can. Feel free to leave any feedback and hope you guys find it satisfactory! |
This is just fantastic! Thank you @gjaldon! ❤️ 💚 💙 💛 💜 |
My pleasure! 😄 |
@gjaldon Awesome! 😮 |
Thanks! :D On Tue, Jun 23, 2015 at 3:40 AM, Sheharyar Naseer notifications@github.com
Gabe Jaldon |
@gjaldon I think doing something like |
@ulrikaugustsson you could customize the commands being run for compiling your assets. Check it out here: |
Okey, sorry! Just thought that a "sane default" would be best but documentation should give the same result. :) 👍 |
I've tested this out and it worked perfectly. Thank you very much @gjaldon. We have a Heroku guide in place here I think the only thing left to close this one out is to get this up on the site. // @lancehalvorsen @jeregrine |
Fabulous! I'm on it. |
Heroku Deployment Guide is now live on phoenixframework.org. Thanks so much @gjaldon for providing the buildpack, and thanks again to @stevedomin for the guide! |
My pleasure, guys! Looking forward to seeing the Heroku guide up on Phoenix Guides. :) |
Howdy folks, following along with the Heroku guide and ran into what is probably a small issue with the secret key and crypto key generation on forms, I think for CSRF stuff – detailed this in #1033 The tooling has really come along nicely! Thanks for so much hard work with the guides, and build packs, etc. 😸 |
@matthewlehner I just responded to the issue you posted |
@matthewlehner @gjaldon sorry about that one, was a last minute change based on some reading I had done, forgot to try it |
No prob at all, @stevedomin. I'm just happy you wrote the guide :) |
@chrismccord @josevalim looks like this is good to close |
Indeed! ❤️ 💚 💙 💛 💜 |
We need a phoenix build pack that is going to compile brunch.io assets on Heroku. The phoenix-static build pack is supposed to play with the existing Elixir buildpack and just add the following steps:
brunch --production
mix phoenix.digest
in the appropriate MIX_ENV to copy the filesFor now, brunch can be hardcoded, but we can make it configurable in the future to support other build tools.
We would really appreciate help from developers interested in tackling and providing this build pack as a separate project!
The text was updated successfully, but these errors were encountered: