Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set session cookie store secret to 64 bytes. #185

Merged
merged 1 commit into from
Jul 15, 2014
Merged

Set session cookie store secret to 64 bytes. #185

merged 1 commit into from
Jul 15, 2014

Conversation

koudelka
Copy link
Contributor

Plug's session cookie store wants the secret to be at least 64 bytes.

https://github.com/elixir-lang/plug/blob/master/lib/plug/session/cookie.ex#L32

@scrogson
Copy link
Contributor

👍

On Tue, Jul 15, 2014 at 11:05 AM, Michael Shapiro
notifications@github.com wrote:

Plug's session cookie store wants the secret to be at least 64 bytes.
https://github.com/elixir-lang/plug/blob/master/lib/plug/session/cookie.ex#L32
You can merge this Pull Request by running:
git pull https://github.com/koudelka/phoenix cookie-secret-length
Or you can view, comment on it, or merge it online at:
#185
-- Commit Summary --

chrismccord added a commit that referenced this pull request Jul 15, 2014
Set session cookie store secret to 64 bytes.
@chrismccord chrismccord merged commit ef4dcad into phoenixframework:master Jul 15, 2014
@koudelka koudelka deleted the cookie-secret-length branch July 15, 2014 16:10
Gazler pushed a commit to Gazler/phoenix that referenced this pull request Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants