improve docker example in release guide #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add python (needed for nodegyp rebuild, will display error otherwise) - mkdir isn't needed, WORKDIR will create the directory if it doesn't exist - combine commands where possible to reduce the amount of docker layers - copy package*.json and install packages before doing the deploy so the install won't happen every time you modify a js/css file or other asset - bash not needed, sh/ash is available - install ncurses-libs, the app wouldn't start otherwise - do the chown when /app is still empty and add chown to the copy command, this saves docker from creating a large layer (about 10Mb) just for the permission changes - add a default cmd - use apk --no-cache so the cache doesn't get added to the image
|
💚 💙 💜 💛 ❤️ |
Gazler
pushed a commit
that referenced
this pull request
Apr 26, 2020
- add python (needed for nodegyp rebuild, will display error otherwise) - mkdir isn't needed, WORKDIR will create the directory if it doesn't exist - combine commands where possible to reduce the amount of docker layers - copy package*.json and install packages before doing the deploy so the install won't happen every time you modify a js/css file or other asset - bash not needed, sh/ash is available - install ncurses-libs, the app wouldn't start otherwise - do the chown when /app is still empty and add chown to the copy command, this saves docker from creating a large layer (about 10Mb) just for the permission changes - add a default cmd - use apk --no-cache so the cache doesn't get added to the image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exist
install won't happen every time you modify a js/css file or other
asset
command, this saves docker from creating a large layer (about 10Mb)
just for the permission changes
I'd actually recommend using docker buildkit to improve performance/caching even more and use more explicit node versions and such but I didn't want to make the example too complicated.
Image size went down almost 20Mb with the changes implemented. You can also change assets now without it needing to reinstall npm packages every time.