Add modern entry point for npm package #4191
Merged
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many JavaScript bundlers nowadays support native ES modules syntax. In fact, ES modules syntax is preferred it is easier to statically analyze and allows tree-shaking to reduce bundle size.
Modern native ESM dev servers like vite or snowpack can also consume the native ESM version of the Phoenix client directly without having to convert it from cjs back to ESM again! However, this is only possible if the Phoenix package specifies the entry point to the file using modern syntax.
This PR adds:
module
field: de-facto standard supported by almost all ESM-supporting bundlers.exports
field: as specified by Node.js. Many modern bundlers are also converging on using this field to conditionally resolve package entry points.