Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CommonJS module along with ESM and IIFE #4512

Merged
merged 1 commit into from Sep 30, 2021
Merged

Build CommonJS module along with ESM and IIFE #4512

merged 1 commit into from Sep 30, 2021

Commits on Sep 28, 2021

  1. Build CommonJS module along with ESM and IIFE 

    esbuild can build CJS modules as well as ESM, and for the people using
build tools / or testing tools (such as Jest) that do not yet support
ESM modules, it is useful to have fallback when ESM is not availalbe.

This PR includes command to build CJS module along with currently
supported types, and adds entry "main" in package.json to point towards
that file.

This has been tested with Jest, which currently has very poor support
for ESM modules and allows for including "phoenix" in tests and also
stubbing it if needed.
    @hubertlepicki
    hubertlepicki committed Sep 28, 2021
    Copy the full SHA
    b06d18f View commit details
    Browse the repository at this point in the history