Add HTMLFormatter in formatter.exs templates

[leandrocp]

That's an attempt to close #4749

The config is added only if @html and Elixir >= 1.13.4 to meet formatter requirements.

[josevalim]

According to this commit we also need to add {:phoenix_live_view, ">= 0.0.0"} at the umbrella root with a comment that it is used exclusively by the formatter: phoenixframework/phoenix_live_view@9793894

Can you please do so?

Thank you!

[leandrocp]

According to this commit we also need to add {:phoenix_live_view, ">= 0.0.0"} at the umbrella root with a comment that it is used exclusively by the formatter: phoenixframework/phoenix_live_view@9793894

Can you please do so?

Thank you!

Sure!

[josevalim]

💚 💙 💜 💛 ❤️

[michallepicki]

For the plugin to work as expected in an umbrella project, the plugin needs to be also added to the top level formatter.exs file in umbrella template, as shown in this comment

[leandrocp]

For the plugin to work as expected in an umbrella project, the plugin needs to be also added to the top level formatter.exs file in umbrella template, as shown in this comment

Thanks @michallepicki just pushed a PR #4800

[chrismccord]

@leandrocp can you check the integration tests on master? I get failures locally on our tests that ensure the generated code is formatted. It fails on layout files and phx.gen.html files, because presumably they have minor tweaks with the formatter. Thanks!

[leandrocp]

@leandrocp can you check the integration tests on master? I get failures locally on our tests that ensure the generated code is formatted. It fails on layout files and phx.gen.html files, because presumably they have minor tweaks with the formatter. Thanks!

Sure. I can reproduce, working on it.

[leandrocp]

@chrismccord one of the changes is adding parens to template functions, eg:

phoenix/installer/templates/phx_web/templates/layout/root.html.heex

Line 8 in dcc7ae5

<%%= live_title_tag assigns[:page_title] || "<%= @app_module %>", suffix: " · Phoenix Framework" %>

is generated and formatted as:

    <%= live_title_tag(assigns[:page_title] || "app", suffix: " · Phoenix Framework") %>

I'm wondering if such functions should be added to locals_without_parens in each related project default .formatter.exs? That would be Phoenix, LiveView, PhoenixHTML.

[chrismccord]

parens is fine. We'll probably convert this to a function component for v1.7. Thanks!