Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eager errors option to core component input fields #5514

Closed
wants to merge 1 commit into from

Conversation

FeeJai
Copy link

@FeeJai FeeJai commented Jul 10, 2023

I had an issue when building an application with both timezone and calendar selection, that the date could become invalid by changing the timezone without the date picker being touched. The error was not shown, since the phx-feedback-for attribute was doing it's job. I have added a feedback slot, that allows to either disable feedback altogether, or set it to eager so it will always be displayed when available. Default does not change current behaviour

This was the question I asked in the form ahead of writing the patch: https://elixirforum.com/t/how-does-liveview-keep-track-of-which-forms-fields-have-been-altered/56014

…rrors eagerly (even if the field has not been edited by the user) or not at all
@FeeJai
Copy link
Author

FeeJai commented Jul 25, 2023

Ping?

@chrismccord
Copy link
Member

This looks like a great option for your app, but not something I think we need to ship out of the box. The core components are meant as starting point and to be adapted to your needs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants