-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sandbox to support new spec for concurrent tests. #44
Conversation
Maybe this is a silly question (feel free to tell me so) but if we're changing the setup examples, does it make sense to only include examples for Hound? For that matter does it make sense to have setup examples at all? Why not just provide some information about the |
Definitely not a silly question. :) Since we have two tools for now, I am fine with listing both in the README. Just send a PR and we can have both there. If the situation changes, we can revisit this, but this is a new and important feature, so the more we talk about it, the better. Does it make sense? |
There were already examples for Hound so I simply updated them. |
@tuvistavie can you release a new Hound? :) |
Please. :) |
@josevalim Yes, I'll do this tomorrow! It's getting late here 😄 |
Beautiful, once you do, let's update the README to mention the version. Have a good night! |
@josevalim, @tuvistavie Sounds good! I'll submit another PR later today. Thanks for taking care of these changes. ❤️ |
@josevalim Hound 1.0 just released 🎉 |
Oh wow, congratulations! @HashNuke, @tuvistavie, and team! 🎉 |
@keathley we are going to announce the Ecto 2.0 rc tomorrow and I would love to include wallaby in the concurrent testing section. Is it already ready for Ecto 2.0 rc that moved the information to the user agent or not yet? Thank you! |
@josevalim I just released the latest version with support for user agent metadata so we're good to go! |
@josevalim Thank you very much for all the feedback you've been giving on our code ~! I've been enjoying & learning reading your detailed feedback. |
@keathley would you be so kind to send a pull request that adds how to use phoenix.ecto with wallaby to the README? bullet points are enough, i will tidy everything up soon. :) |
@josevalim Done :) |
I updated the sandbox to work as we discussed in #41.
I still need to fix a last issue in Hound before I publish a release with the metadata functionality.