Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sandbox to support new spec for concurrent tests. #44

Merged
merged 1 commit into from
Apr 17, 2016

Conversation

danhper
Copy link

@danhper danhper commented Apr 17, 2016

I updated the sandbox to work as we discussed in #41.

I still need to fix a last issue in Hound before I publish a release with the metadata functionality.

@keathley
Copy link
Contributor

Maybe this is a silly question (feel free to tell me so) but if we're changing the setup examples, does it make sense to only include examples for Hound? For that matter does it make sense to have setup examples at all? Why not just provide some information about the Sandbox plug and then link to the testing libraries themselves?

@josevalim
Copy link
Member

Definitely not a silly question. :)

Since we have two tools for now, I am fine with listing both in the README. Just send a PR and we can have both there.

If the situation changes, we can revisit this, but this is a new and important feature, so the more we talk about it, the better.

Does it make sense?

@danhper
Copy link
Author

danhper commented Apr 17, 2016

There were already examples for Hound so I simply updated them.
I think that if we update the docs we should do this in another PR, but I have no strong opinion about either adding examples for other libraries or removing the examples and leaving only links.

@josevalim josevalim merged commit e165dde into phoenixframework:master Apr 17, 2016
@danhper danhper deleted the new-sandbox-spec branch April 17, 2016 16:35
@josevalim
Copy link
Member

@tuvistavie can you release a new Hound? :)

@josevalim
Copy link
Member

Please. :)

@danhper
Copy link
Author

danhper commented Apr 17, 2016

@josevalim Yes, I'll do this tomorrow! It's getting late here 😄

@josevalim
Copy link
Member

Beautiful, once you do, let's update the README to mention the version. Have a good night!

@keathley
Copy link
Contributor

@josevalim, @tuvistavie Sounds good! I'll submit another PR later today.

Thanks for taking care of these changes. ❤️

@danhper
Copy link
Author

danhper commented Apr 18, 2016

@josevalim Hound 1.0 just released 🎉

@josevalim
Copy link
Member

Oh wow, congratulations! @HashNuke, @tuvistavie, and team! 🎉

@josevalim
Copy link
Member

@keathley we are going to announce the Ecto 2.0 rc tomorrow and I would love to include wallaby in the concurrent testing section. Is it already ready for Ecto 2.0 rc that moved the information to the user agent or not yet? Thank you!

@keathley
Copy link
Contributor

@josevalim I just released the latest version with support for user agent metadata so we're good to go!

@HashNuke
Copy link

@josevalim Thank you very much for all the feedback you've been giving on our code ~! I've been enjoying & learning reading your detailed feedback.

@josevalim
Copy link
Member

@keathley would you be so kind to send a pull request that adds how to use phoenix.ecto with wallaby to the README? bullet points are enough, i will tidy everything up soon. :)

@keathley
Copy link
Contributor

@josevalim Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants