This repository has been archived by the owner. It is now read-only.

Adds Heroku deploy guide #314

Merged
merged 1 commit into from Jul 14, 2015

Conversation

Projects
None yet
4 participants
@stevedomin
Contributor

stevedomin commented Jul 7, 2015

WIP

This is not 100% done yet but I wanted to get some early feedback while I was finishing/polishing it.

In the last section I plan to add something about running iex console and running migrations.

I'm also wondering whether to use an app with Ecto as an example (instead of the Phoenix welcome app).

@lancehalvorsen

This comment has been minimized.

Show comment
Hide comment
@lancehalvorsen

lancehalvorsen Jul 7, 2015

Member

@stevedomin thank you very much for this! I'll be adding some comments inline, but this will be a great addition to the guides. :)

Member

lancehalvorsen commented Jul 7, 2015

@stevedomin thank you very much for this! I'll be adding some comments inline, but this will be a great addition to the guides. :)

Our main goal for this is guide is to get a Phoenix application running on Heroku.
## Steps

This comment has been minimized.

@lancehalvorsen

lancehalvorsen Jul 7, 2015

Member

What would you think about adding a quick sentence here to lead into the list of sections? Iirc, there's a sentence in the Exrm Releases Guide that fulfills this purpose.

@lancehalvorsen

lancehalvorsen Jul 7, 2015

Member

What would you think about adding a quick sentence here to lead into the list of sections? Iirc, there's a sentence in the Exrm Releases Guide that fulfills this purpose.

@stevedomin

This comment has been minimized.

Show comment
Hide comment
@stevedomin

stevedomin Jul 9, 2015

Contributor

Woah, thanks for all the comments @lancehalvorsen, will have a more thorough look tonight

Contributor

stevedomin commented Jul 9, 2015

Woah, thanks for all the comments @lancehalvorsen, will have a more thorough look tonight

@stevedomin

This comment has been minimized.

Show comment
Hide comment
@stevedomin

stevedomin Jul 11, 2015

Contributor

@lancehalvorsen I went over all your comments and updated the guide. Can you let me know what you think now? Thanks a lot for the extensive review and sorry for all the bad english grammar

Contributor

stevedomin commented Jul 11, 2015

@lancehalvorsen I went over all your comments and updated the guide. Can you let me know what you think now? Thanks a lot for the extensive review and sorry for all the bad english grammar

@lancehalvorsen

This comment has been minimized.

Show comment
Hide comment
@lancehalvorsen

lancehalvorsen Jul 11, 2015

Member

@stevedomin this is shaping up really, really well! The next step is for me to follow all the instructions line by line, as a reader would, to see if there is anything that needs clarification.

Also, no need to apologize whatsoever. :^) To paraphrase a recent Steve Klabnik tweet, writing documentation is really hard, and nobody wants to do it, but it's incredibly important. Your efforts here are really helpful. <3

Member

lancehalvorsen commented Jul 11, 2015

@stevedomin this is shaping up really, really well! The next step is for me to follow all the instructions line by line, as a reader would, to see if there is anything that needs clarification.

Also, no need to apologize whatsoever. :^) To paraphrase a recent Steve Klabnik tweet, writing documentation is really hard, and nobody wants to do it, but it's incredibly important. Your efforts here are really helpful. <3

Buildpack set. Next release on mysterious-meadow-6277 will use https://github.com/HashNuke/heroku-buildpack-elixir.git.
https://mysterious-meadow-6277.herokuapp.com/ | https://git.heroku.com/mysterious-meadow-6277.git
Git remote heroku added
```

This comment has been minimized.

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

I was prompted for my Heroku credentials here - email and password. We might want to alert readers to be ready for this.

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

I was prompted for my Heroku credentials here - email and password. We might want to alert readers to be ready for this.

This comment has been minimized.

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

We might also want to let folks know that the results of this command will give them the url to their application. In this case, it's "https://mysterious-meadow-6277.herokuapp.com/", but theirs will be different.

It might be worth mentioning that they can go see the application in a browser at this point, but it will be a generic Heroku generated welcome page.

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

We might also want to let folks know that the results of this command will give them the url to their application. In this case, it's "https://mysterious-meadow-6277.herokuapp.com/", but theirs will be different.

It might be worth mentioning that they can go see the application in a browser at this point, but it will be a generic Heroku generated welcome page.

This comment has been minimized.

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

I have one final bit about this section, I promise. :)

When I did this, I hadn't initialized my project as a git repo before I created the application, so I didn't get the "Git remote heroku added" line in the output. I had to add the remote manually. We could prevent a lot of problems by mentioning those instructions here.

$ heroku git:remote -a mysterious-meadow-6277
Installing Heroku Toolbelt v4... done
Installing plugin heroku-git... done
set git remote heroku to https://git.heroku.com/mysterious-meadow-6277.git

@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

I have one final bit about this section, I promise. :)

When I did this, I hadn't initialized my project as a git repo before I created the application, so I didn't get the "Git remote heroku added" line in the output. I had to add the remote manually. We could prevent a lot of problems by mentioning those instructions here.

$ heroku git:remote -a mysterious-meadow-6277
Installing Heroku Toolbelt v4... done
Installing plugin heroku-git... done
set git remote heroku to https://git.heroku.com/mysterious-meadow-6277.git

@lancehalvorsen

This comment has been minimized.

Show comment
Hide comment
@lancehalvorsen

lancehalvorsen Jul 13, 2015

Member

@stevedomin we're nearly there! I just made a few comments after working through this from scratch on my own.

This is a big contribution that's going to be really useful for the community. Thanks so much!

Member

lancehalvorsen commented Jul 13, 2015

@stevedomin we're nearly there! I just made a few comments after working through this from scratch on my own.

This is a big contribution that's going to be really useful for the community. Thanks so much!

Show outdated Hide outdated deployment/E_heroku.md
Show outdated Hide outdated deployment/E_heroku.md
Show outdated Hide outdated deployment/E_heroku.md
In fact, we can run anything using the `heroku run` command, like the Ecto migration task for instance:
```console
$ heroku run mix ecto.migrate

This comment has been minimized.

@gjaldon

gjaldon Jul 13, 2015

Contributor

Maybe point out that we can automate this by adding this command to a CI?

@gjaldon

gjaldon Jul 13, 2015

Contributor

Maybe point out that we can automate this by adding this command to a CI?

This comment has been minimized.

@stevedomin

stevedomin Jul 14, 2015

Contributor

I feel like this would be out of the scope of this guide. What do you think?

@stevedomin

stevedomin Jul 14, 2015

Contributor

I feel like this would be out of the scope of this guide. What do you think?

This comment has been minimized.

@gjaldon

gjaldon Jul 14, 2015

Contributor

Was thinking just a mention but avoid going in-depth. Just a thought. Anyway, thanks for this! :)

@gjaldon

gjaldon Jul 14, 2015

Contributor

Was thinking just a mention but avoid going in-depth. Just a thought. Anyway, thanks for this! :)

@stevedomin

This comment has been minimized.

Show comment
Hide comment
@stevedomin

stevedomin Jul 14, 2015

Contributor

@lancehalvorsen I fixed all the things you mentioned, plus made some changes here and there, might be worth having another read if you don't mind. Thanks!

Contributor

stevedomin commented Jul 14, 2015

@lancehalvorsen I fixed all the things you mentioned, plus made some changes here and there, might be worth having another read if you don't mind. Thanks!

@lancehalvorsen

This comment has been minimized.

Show comment
Hide comment
@lancehalvorsen

lancehalvorsen Jul 14, 2015

Member

@stevedomin thanks so, so much. This is a huge help, and you've been wonderfully patient through all of my fussy comments!

@gjaldon thank you as well for chiming in. Good to see you around again. :^)

Member

lancehalvorsen commented Jul 14, 2015

@stevedomin thanks so, so much. This is a huge help, and you've been wonderfully patient through all of my fussy comments!

@gjaldon thank you as well for chiming in. Good to see you around again. :^)

lancehalvorsen added a commit that referenced this pull request Jul 14, 2015

@lancehalvorsen lancehalvorsen merged commit 247e085 into phoenixframework:master Jul 14, 2015

@dbackeus

This comment has been minimized.

Show comment
Hide comment
@dbackeus

dbackeus Jul 14, 2015

Contributor

Congrats for landing this contribution! 👍

Looking forward to see it on the guides page :)

Contributor

dbackeus commented Jul 14, 2015

Congrats for landing this contribution! 👍

Looking forward to see it on the guides page :)

@stevedomin stevedomin deleted the stevedomin:heroku-deploy branch Jul 14, 2015

@stevedomin

This comment has been minimized.

Show comment
Hide comment
@stevedomin

stevedomin Jul 14, 2015

Contributor

Awesome, looking forward to seeing it live!

Contributor

stevedomin commented Jul 14, 2015

Awesome, looking forward to seeing it live!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.