Adds Heroku deploy guide #314
Conversation
|
@stevedomin thank you very much for this! I'll be adding some comments inline, but this will be a great addition to the guides. :) |
| ## FPO | ||
| ### What we'll need | ||
|
|
||
| - a working application |
There was a problem hiding this comment.
Perhaps we could have a full sentence here?
|
Woah, thanks for all the comments @lancehalvorsen, will have a more thorough look tonight |
stevedomin
force-pushed
the
heroku-deploy
branch
2 times, most recently
from
9d4dab3
to
8360e9a
Compare
|
@lancehalvorsen I went over all your comments and updated the guide. Can you let me know what you think now? Thanks a lot for the extensive review and sorry for all the bad english grammar |
|
@stevedomin this is shaping up really, really well! The next step is for me to follow all the instructions line by line, as a reader would, to see if there is anything that needs clarification. Also, no need to apologize whatsoever. :^) To paraphrase a recent Steve Klabnik tweet, writing documentation is really hard, and nobody wants to do it, but it's incredibly important. Your efforts here are really helpful. <3 |
| The only thing we'll need for this guide is a working Phoenix application. | ||
|
|
||
| If you don't already have one, just run `mix phoenix.new hello_phoenix` in a terminal and you're good to go. | ||
|
|
There was a problem hiding this comment.
I think it would be a good idea to prompt readers to git init their project right here if they haven't yet done so. It might also be useful to say that the reason we're doing that is the style of Heroku deployment we'll be doing is based on git.
|
@stevedomin we're nearly there! I just made a few comments after working through this from scratch on my own. This is a big contribution that's going to be really useful for the community. Thanks so much! |
| We need to compile static assets for a successful Phoenix deployment. The [Phoenix static buildpack](https://github.com/gjaldon/heroku-buildpack-phoenix-static) can take of that for us, so let's add it now. | ||
|
|
||
| ```console | ||
| $ heroku buildpacks:add https://github.com/gjaldon/phoenix-static-buildpack |
There was a problem hiding this comment.
phoenix-static-buildpack has been renamed to heroku-buildpack-phoenix-static and since you use https://github.com/gjaldon/heroku-buildpack-phoenix-static above, let's keep it consistent. :)
stevedomin
force-pushed
the
heroku-deploy
branch
from
8360e9a
to
adc5611
Compare
|
@lancehalvorsen I fixed all the things you mentioned, plus made some changes here and there, might be worth having another read if you don't mind. Thanks! |
|
@stevedomin thanks so, so much. This is a huge help, and you've been wonderfully patient through all of my fussy comments! @gjaldon thank you as well for chiming in. Good to see you around again. :^) |
Adds Heroku deploy guide
|
Congrats for landing this contribution! 👍 Looking forward to see it on the guides page :) |
|
Awesome, looking forward to seeing it live! |
WIP
This is not 100% done yet but I wanted to get some early feedback while I was finishing/polishing it.
In the last section I plan to add something about running
iexconsole and running migrations.I'm also wondering whether to use an app with Ecto as an example (instead of the Phoenix welcome app).