using Path.join/1 to prevent double / issues

phoenixframework · Oct 26, 2023 · 67f36e1 · 67f36e1
1 parent 17daa01
commit 67f36e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/phoenix/live_dashboard/layout_view.ex b/lib/phoenix/live_dashboard/layout_view.ex
@@ -27,7 +27,7 @@ defmodule Phoenix.LiveDashboard.LayoutView do
       Phoenix.VerifiedRoutes.unverified_path(
         conn,
         conn.private.phoenix_router,
-        "#{prefix}/#{asset}-#{hash}"
+        Path.join([prefix, "#{asset}-#{hash}"])
       )
     else
       apply(

diff --git a/lib/phoenix/live_dashboard/page_builder.ex b/lib/phoenix/live_dashboard/page_builder.ex
@@ -982,9 +982,9 @@ defmodule Phoenix.LiveDashboard.PageBuilder do
 
       path =
         if node == node() and is_nil(old_params["node"]) do
-          "#{prefix}/#{route}"
+          Path.join([prefix, to_string(route)])
         else
-          "#{prefix}/#{URI.encode_www_form(to_string(node))}/#{route}"
+          Path.join([prefix, URI.encode_www_form(to_string(node)), to_string(route)])
         end
 
       Phoenix.VerifiedRoutes.unverified_path(socket, socket.router, path, new_params)