Skip to content

Commit

Permalink
Do not send the whole metadata across processes
Browse files Browse the repository at this point in the history
  • Loading branch information
josevalim committed Mar 11, 2024
1 parent 5d51a11 commit 71f0ee2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
6 changes: 3 additions & 3 deletions lib/phoenix_live_reload/channel.ex
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ defmodule Phoenix.LiveReloader.Channel do
{:noreply, socket}
end

def handle_info({@logs, %{level: level, msg: msg, meta: meta}}, socket) do
def handle_info({@logs, %{level: level, msg: msg, file: file, line: line}}, socket) do
push(socket, "log", %{
level: to_string(level),
msg: msg,
file: meta[:file],
line: meta[:line]
file: file,
line: line
})

{:noreply, socket}
Expand Down
7 changes: 5 additions & 2 deletions lib/phoenix_live_reload/web_console_logger.ex
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ defmodule Phoenix.LiveReloader.WebConsoleLogger do
msg = IO.iodata_to_binary(iodata)

Registry.dispatch(@registry, :all, fn entries ->
for {pid, prefix} <- entries,
do: send(pid, {prefix, %{level: level, msg: msg, meta: meta}})
event = %{level: level, msg: msg, file: meta[:file], line: meta[:line]}

for {pid, prefix} <- entries do
send(pid, {prefix, event})
end
end)
end
end

0 comments on commit 71f0ee2

Please sign in to comment.