Skip to content

Commit

Permalink
Remove unused join key
Browse files Browse the repository at this point in the history
  • Loading branch information
chrismccord committed Feb 27, 2024
1 parent e6078a2 commit d7039e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/phoenix_live_reload/channel.ex
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ defmodule Phoenix.LiveReloader.Channel do

defp join_info do
if url = System.get_env("PLUG_EDITOR") do
%{editor_url: url, relative_path: File.cwd!()}
%{editor_url: url}
else
%{}
end
Expand Down
6 changes: 2 additions & 4 deletions test/channel_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ defmodule Phoenix.LiveReloader.ChannelTest do
@endpoint MyApp.LogEndpoint
test "sends logs for web console only when enabled" do
System.delete_env("PLUG_EDITOR")

update_live_reload_env(@endpoint, fn conf ->
Keyword.drop(conf, [:web_console_logger])
end)
Expand Down Expand Up @@ -149,9 +150,6 @@ defmodule Phoenix.LiveReloader.ChannelTest do
{:ok, info, _socket} =
LiveReloader.Socket |> socket() |> subscribe_and_join(Channel, "phoenix:live_reload", %{})

assert info == %{
editor_url: "vscode://file/__FILE__:__LINE__",
relative_path: File.cwd!()
}
assert info == %{editor_url: "vscode://file/__FILE__:__LINE__"}
end
end

0 comments on commit d7039e4

Please sign in to comment.