Submit phx-value-* attributes on <form> in tests

phoenixframework · May 24, 2024 · 92281f1 · 92281f1
1 parent e742ca8
commit 92281f1
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/lib/phoenix_live_view/test/client_proxy.ex b/lib/phoenix_live_view/test/client_proxy.ex
@@ -1101,7 +1101,11 @@ defmodule Phoenix.LiveViewTest.ClientProxy do
 
         with {:ok, defaults} <- maybe_submitter(defaults, type, node, element),
              {:ok, value} <- fill_in_map(Enum.to_list(element.form_data || %{}), "", node, []) do
-          {:ok, DOM.deep_merge(Query.decode_done(defaults), value)}
+          {:ok,
+           defaults
+           |> Query.decode_done()
+           |> DOM.deep_merge(DOM.all_values(node))
+           |> DOM.deep_merge(value)}
         else
           {:error, _, _} = error -> error
         end

diff --git a/test/phoenix_live_view/integrations/elements_test.exs b/test/phoenix_live_view/integrations/elements_test.exs
@@ -467,6 +467,11 @@ defmodule Phoenix.LiveView.ElementsTest do
       assert last_event(view) =~ ~s|form-submit: %{"foo" => "bar"}|
     end
 
+    test "submits data passed as phx-value-* attributes", %{live: view} do
+      assert view |> element("#phx-value-form") |> render_submit()
+      assert last_event(view) =~ ~s|form-submit: %{"foo" => "bar", "key" => "val"}|
+    end
+
     test "raises on invalid submitter", %{live: view} do
       assert_raise ArgumentError, ~r"invalid form submitter", fn ->
         assert view

diff --git a/test/support/live_views/elements.ex b/test/support/live_views/elements.ex
@@ -60,7 +60,9 @@ defmodule Phoenix.LiveViewTest.ElementsLive do
 
     <%# forms %>
     <a id="a-no-form" phx-change="hello" phx-submit="world">Change</a>
-    <form id="empty-form" phx-change="form-change" phx-submit="form-submit" phx-value-key="value">
+    <form id="empty-form" phx-change="form-change" phx-submit="form-submit">
+    </form>
+    <form id="phx-value-form" phx-change="form-change" phx-submit="form-submit" phx-value-key="val" phx-value-foo="bar">
     </form>
     <form id="form" phx-change="form-change" phx-submit="form-submit" phx-value-key="value">
       <input value="no-name">