Format EEx blocks within script tag, closes #3312

phoenixframework · Jun 21, 2024 · f6f8f9c · f6f8f9c
1 parent 8f39fd6
commit f6f8f9c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/phoenix_live_view/html_algebra.ex b/lib/phoenix_live_view/html_algebra.ex
@@ -267,15 +267,15 @@ defmodule Phoenix.LiveView.HTMLAlgebra do
   end
 
   # Handle EEX blocks within preserve tags
-  defp to_algebra({:eex_block, expr, block}, %{mode: :preserve} = context) do
+  defp to_algebra({:eex_block, expr, block, meta}, %{mode: :preserve} = context) do
     doc =
       Enum.reduce(block, empty(), fn {block, expr}, doc ->
         children = block_to_algebra(block, context)
         expr = "<% #{expr} %>"
         concat([doc, children, expr])
       end)
 
-    {:block, group(concat("<%= #{expr} %>", doc))}
+    {:block, group(concat("<%#{meta.opt} #{expr} %>", doc))}
   end
 
   # Handle EEX blocks

diff --git a/test/phoenix_live_view/html_formatter_test.exs b/test/phoenix_live_view/html_formatter_test.exs
@@ -1183,6 +1183,26 @@ defmodule Phoenix.LiveView.HTMLFormatterTest do
     """)
   end
 
+  test "formats eex blocks within script tag" do
+    assert_formatter_doesnt_change("""
+    <script>
+      var foo = 1;
+      <%= if @bar do %>
+      var bar = 2;
+      <% end %>
+    </script>
+    """)
+
+    assert_formatter_doesnt_change("""
+    <script>
+      var foo = 1;
+      <% if @bar do %>
+      var bar = 2;
+      <% end %>
+    </script>
+    """)
+  end
+
   test "formats style tag" do
     input = """
     <div>