-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
morphdom not found because phoenix_html imported w/o deps path #1505
Comments
once #1507 is merged you need to clean your |
resolves the need to specify deps location for phoenix_html (or mix wasn't pulling the latest github project - I changed it to use specific refs as I noticed it didn't pull in latest lv from github) in {
"name": "assets",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"dependencies": {
...
"phoenix": "file:../deps/phoenix",
"phoenix_html": "file:../deps/phoenix_html",
"phoenix_live_view": "file:../deps/phoenix_live_view",
"topbar": "^1.0.1"
},
...
"phoenix": {
"version": "file:../deps/phoenix"
},
"phoenix_html": {
"version": "file:../deps/phoenix_html"
},
"phoenix_live_view": {
"version": "file:../deps/phoenix_live_view",
"requires": {
"morphdom": "2.6.1"
}
},
...
|
npm v7 broke file-based dependency fetching. Either downgrading to npm v6, or referencing phoenix_live_view as a git/npm dep will bring things back to working: To reference from GitHub:
|
Environment
Actual behavior
I tried pulling the master branch in to test out the webpack 5 build. I get this error when starting the app. I noticed in the changelog there is a bug fix with a description quite similar to what I'm experiencing but I can't see an issue or PR related.
I found this answer on stackoverflow which says to replace
import "phoenix_html"
import "../../deps/phoenix_html"
. I had to make this change andcd deps/phoenix_live_view/assets
and runnpm i
for it to work.I feel like I've missed a step somewhere...?
Expected behavior
app runs
The text was updated successfully, but these errors were encountered: