-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable production source maps #1502
Conversation
Amended compiled JS & Source Maps as discussed with @bcardarella |
@chrismccord 👍 from me on this, should be OK to merge |
@maennchen thank you! Can you back out the precompiled changes and I will rebuild after merging? We prefer to avoid precompiled builds in PRs for conflicts and security reasons. Thanks! |
@chrismccord the pre-compile is necessary to reference the sourcemap file, otherwise the js console won't know how to associate the two |
to be clear, I will build the the source/maps after I merge and everything else is perfect, we just prefer to avoid merging minified/compiled js since it can be an easy security backdoor as it is not human readable. |
@chrismccord ah ok, makes sense 👍 |
@chrismccord / @bcardarella The dist files are now removed. |
@chrismccord / @bcardarella Is there any change needed on this PR? |
Should be OK to merge |
❤️❤️❤️🐥🔥 |
phoenix
counter-part Add SourceMaps to minified JS phoenix#4276