Live reloading LiveViews without a hard refresh #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 11, 2022
chrismccord
reviewed
Nov 11, 2022
mix.exs
Outdated
| @@ -46,7 +46,8 @@ defmodule Phoenix.LiveView.MixProject do | |||
| {:floki, "~> 0.30.0", only: :test}, | |||
| {:ex_doc, "~> 0.28", only: :docs}, | |||
| {:makeup_eex, ">= 0.1.1", only: :docs}, | |||
| {:html_entities, ">= 0.0.0", only: :test} | |||
| {:html_entities, ">= 0.0.0", only: :test}, | |||
| {:phoenix_live_reload, path: "../phoenix_live_reload", only: :test, override: true} | |||
There was a problem hiding this comment.
This will need to point to hex once we release live reload
chrismccord
reviewed
Nov 11, 2022
josevalim
reviewed
Nov 12, 2022
| Utils.force_assign(socket, key, val) | ||
| end) | ||
|
|
||
| handle_changed(state, new_socket, nil) |
There was a problem hiding this comment.
This is tricky because if the user changed mount or handle_params, those wouldn't be picked up. I partially feel the best way to go around this is to send a client a refresh and the client performs a full remount. Probably doing the changes in #2326.
chrismccord
reviewed
Nov 29, 2022
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the complementary changes in the phoenix_live_reload Repo.