-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live reloading LiveViews without a hard refresh #2323
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
15371ed
render diffs without full page reload
bemesa21 da23649
accepts multiple topics-patterns
bemesa21 8f72b63
fix tests, add live reload test
bemesa21 13d6aa4
subscribe just to live_view topic
bemesa21 c4281c3
Update mix.exs
chrismccord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,8 @@ defmodule Phoenix.LiveView.MixProject do | |
{:floki, "~> 0.30.0", only: :test}, | ||
{:ex_doc, "~> 0.28", only: :docs}, | ||
{:makeup_eex, ">= 0.1.1", only: :docs}, | ||
{:html_entities, ">= 0.0.0", only: :test} | ||
{:html_entities, ">= 0.0.0", only: :test}, | ||
{:phoenix_live_reload, path: "../phoenix_live_reload", only: :test, override: true} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to point to hex once we release live reload
chrismccord marked this conversation as resolved.
Show resolved
Hide resolved
|
||
] | ||
end | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
defmodule Phoenix.LiveView.LiveReloadTest do | ||
use ExUnit.Case, async: false | ||
|
||
import Phoenix.ConnTest | ||
import Phoenix.ChannelTest | ||
import Phoenix.LiveViewTest | ||
|
||
alias Phoenix.LiveReloader | ||
alias Phoenix.LiveReloader.Channel | ||
alias Phoenix.LiveView.LiveReloadTestHelpers, as: Helpers | ||
|
||
@endpoint Helpers.Endpoint | ||
@pubsub Phoenix.LiveView.PubSub | ||
|
||
setup config do | ||
ExUnit.CaptureLog.capture_log(fn -> | ||
start_supervised!(@endpoint) | ||
|
||
{:ok, _} = | ||
Supervisor.start_link([Phoenix.PubSub.child_spec(name: @pubsub)], | ||
strategy: :one_for_one | ||
) | ||
end) | ||
|
||
{:ok, _, socket} = | ||
LiveReloader.Socket |> socket() |> subscribe_and_join(Channel, "phoenix:live_reload", %{}) | ||
conn = Plug.Test.init_test_session(build_conn(), config[:session] || %{}) | ||
{:ok, conn: conn, socket: socket} | ||
end | ||
|
||
test "LiveView renders again when the phoenix_live_reload is received", %{conn: conn, socket: socket} do | ||
Phoenix.PubSub.subscribe(@pubsub, "liveview") | ||
|
||
Application.put_env(:phoenix_live_view, :vsn, 1) | ||
{:ok, lv, _html} = live(conn, "/live-reload") | ||
assert render(lv) =~ "<div>Version 1</div>" | ||
|
||
send(socket.channel_pid, {:file_event, self(), {"lib/test_auth_web/live/user_live.ex", :created}}) | ||
Application.put_env(:phoenix_live_view, :vsn, 2) | ||
|
||
assert_receive {:phoenix_live_reload, :liveview, "lib/test_auth_web/live/user_live.ex"} | ||
assert render(lv) =~ "<div>Version 2</div>" | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tricky because if the user changed
mount
orhandle_params
, those wouldn't be picked up. I partially feel the best way to go around this is to send a client a refresh and the client performs a full remount. Probably doing the changes in #2326.