Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix.LiveViewTest doesn't work without session #822

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

egze
Copy link
Contributor

@egze egze commented Apr 25, 2020

Issue: #820

Calling the live macro in tests blows up if the session has not been fetched yet. This is a problem if the application is configured to not have any sessions.

Please let me me know if this is the right direction. Also I am struggling to write a test for it. How would I setup the conn without a fetched session?

@josevalim josevalim merged commit 220d9f7 into phoenixframework:master Apr 26, 2020
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@josevalim
Copy link
Member

I have pushed a quick test. :) thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants