Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done on top of #108 and #109.
This PR is an attempt to fix issues discovered by the property based tests that can generate split and join network between certain nodes:
This counterexample reproduced a case when joins are propagated via netsplit (node 1 stores information about sessions connected to node 3 internally), but leaves are not -- when the node 3 sessions are disconnected and the split is healed, these sessions still appear to be connected on node 1.
The proposed solution makes the filter in
observe_removes
less strict. I'm not sure what performance implications this might have, though.This counterexample occasionally reproduces a situation when some of the sessions connected to node 3 never appear on node 2.
It seems that sometimes a merge of two deltas was possible, when their ranges were not contiguous. The proposed solution makes the deltas adjacency check more strict.
cc @pzel