Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement search, sort picker, favorite games, and sort by recency #52

Merged
merged 12 commits into from
Aug 27, 2023
Merged

Implement search, sort picker, favorite games, and sort by recency #52

merged 12 commits into from
Aug 27, 2023

Conversation

jxhug
Copy link
Member

@jxhug jxhug commented Aug 26, 2023 •
edited
Loading

also fix enum conventions

closes #51, #49, #42

@jxhug
set commandgroup placement to sidebar
95429d6 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
search working
1ab9ab1 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
made sidebar code more modular
ea58bc7 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
added sort picker and alphabetical sorting
87a22d1 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
fix enum syntax / conventions
4178ae2 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
implement sort by recency
6e98549 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug jxhug added the enhancement New feature or request label Aug 26, 2023
@jxhug jxhug requested a review from Shock9616 August 26, 2023 19:07
@jxhug
implement favorite games
3c359e0 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug jxhug changed the title Implement search, sort picker, and sort by recency Implement search, sort picker, favorite games, and sort by recency Aug 26, 2023
@Shock9616
Copy link
Member

Shock9616 commented Aug 26, 2023 •
edited
Loading

Would it be possible to have the sort-by button in the same location, just smaller, when the side bar is too small? And maybe have it be the same button but with only the icon showing or something like that?
Screenshot 2023-08-26 at 12 30 20 PM
Looks great otherwise!

@jxhug jxhug linked an issue Aug 26, 2023 that may be closed by this pull request
Add the ability to tag games as favourites #49
Closed
@jxhug
implement play game button and shortcut
08a3122 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
add setting for text in picker
17fd168 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
added toggle for picker
d7a789c 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
add defaults
acbf1b9 
Signed-off-by: James Hughes <james@jxhug.me>
@jxhug
small width fix
fb5b7a7 
Signed-off-by: James Hughes <james@jxhug.me>
Shock9616
Shock9616 approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@Shock9616 Shock9616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shock9616 Shock9616 merged commit 4543c95 into phoenixlauncher:main Aug 27, 2023
@jxhug jxhug mentioned this pull request Aug 27, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shock9616 Shock9616 Shock9616 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

different sorting for sidebar Add the ability to tag games as favourites
2 participants
@jxhug @Shock9616