-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert configs/localization to JSON #39
Labels
Comments
phogue
pushed a commit
that referenced
this issue
Jan 18, 2014
phogue
pushed a commit
that referenced
this issue
Jan 18, 2014
phogue
pushed a commit
that referenced
this issue
Jan 18, 2014
The class "JsonConfig" will be renamed to "Config" once refactoring is completed
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
I don't think this code was being used outside of unit tests though?
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
phogue
pushed a commit
that referenced
this issue
Jan 19, 2014
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently use XML for configs and support XML and JSON for commands going back and forth over the command server. Every serialization issue so far has been with XML.
If we are to support XML it would require lots of messy tags through out the models. This has already occurred in some models, but when dealing with serialization of interfaces it would mean I would now need to all but implement the serialization myself.
The easier option is to ditch XML and just support JSON. This would mean one serialization type to test, it would be my preferred transport type and a pretty killer library that will handle the serialization for us.
The events disk logging, while optional, is also done in XML. Using JSON will cut a small test section I did by two thirds.
We can use the newtonsoft json library to convert the existing xml config files for BF4 to JSON.
The text was updated successfully, but these errors were encountered: