WP8 plugin #6

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
8 participants

Added a WP8 plugin from my phonegap project

jdhiro commented Sep 10, 2013

I just want to voice my support for adding WP8 =) We're planning to offer our app on WP8 as well in the future, and it would be great to have the notifications there.

bobeast commented Sep 10, 2013

Updates to the plugins located here are typically driven by what is supported on PhoneGap Build. We are necessarily behind Cordova.

That said, we will definitely consider this once WP8 support is available on Build.

rjmunro commented Sep 18, 2013

@bobeast So those of us who don't use phonegap build & need new features need to start another fork of PushPlugin? phonegap-build's plugins should not be considered the de facto standard?

bobeast commented Sep 18, 2013

The plugins on phone-gap build are maintained to work with the versions of Cordova that PhoneGap Build supports. PhoneGap Build is often behind Cordova version releases.

If you need a plugin to support a version of Cordova that is not yet supported on PhoneGap Build, the appropriate action is to fork the plugin, and make changes to your fork necessary to support the new version. Its actually a pretty rare occurrence that a new release of Cordova introduces backwards compatibility issues. 3.0.0 is unfortunately, one of those exceptions.

Bonus points, for submitting a Pull Request back to PhoneGap Build for consideration when PhoneGap Build updates its Cordova support.

@bobeast It's been nearly 4 months since PhoneGap Build announced beta WP8 support - any idea when GA will actually happen?

Member

EddyVerbruggen commented Feb 20, 2014

Please pull it, I'd be glad to test it.

@bobeast Hey Bob! Any news on an update for this now that PhoneGap Build supports WP8?

+
+ <script type="text/javascript" charset="utf-8" src="PushNotification.js"></script>
+
+## Automatic Installation (not possible for WP8)
@sgrebnov

sgrebnov Feb 27, 2014

Can someone elaborate on this? I don't see any restrictions here. We just need to add the following to plugin.xml

<!-- Windows Phone -->
<platform name="wp8">
    <config-file target="config.xml" parent="/*">
        <feature name="PushPlugin">
            <param name="wp-package" value="PushPlugin"/>
        </feature>
    </config-file>
    <config-file target="Properties/WMAppManifest.xml" parent="/Deployment/App/Capabilities">
        <Capability Name="ID_CAP_PUSH_NOTIFICATION"/>
    </config-file>
    <source-file src="src/wp/PushPlugin.cs" />
</platform>
Member

EddyVerbruggen commented Mar 14, 2014

Hi @darkphantum, thank you very much for the PR. The kind people at Phonegap allowed me write access to this repo, so I've just committed the WP8 implementation, largely based on your changes.

I hope we can move this feature to PhoneGap Build quickly.

Thanks,
Eddy

Member

EddyVerbruggen commented May 1, 2014

Hi, just committed a few enhancements based on another PR, I really hope it will be available on Build soon. For people not using Build: please go ahead updating the plugin and test the enhancements (see the readme for details).

oliversalzburg pushed a commit to fairmanager-cordova/PushPlugin that referenced this pull request Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment