Simplified http proxy for cross domain requests. Should help #175 and #7... #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#175 and phonegap#74. Also rewrite the location head in case the target sends one.
|
Just applied this patch and it also solves some problems with the proxy for us. Thanks for the work. |
|
@killfill beauty! Thanks for rewriting this implementation. It's done well and a lot cleaner than my approach. |
mwbrooks
added a commit
that referenced
this pull request
Jan 7, 2015
mwbrooks
added a commit
that referenced
this pull request
Jan 7, 2015
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had some problems with the proxing, and was reading #74 and #175, and decided to send you guys a PR to make the http-proxy a little simplier.
This uses node-http-proxy to handle the proxing and rewrites the location header in case the target sends one.
This way if the 'api backend' responds a redirect, the browser follow it.. :)
Also it does not mess up with the body building, which was the problem in my use-case.
Happy new year!