[#17] updated README with deployment instructions to Firebase, added … #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firebase config files
…rapped firebase-cli commands as npm run commands
|
This looks fine to me, though I don't know heaps about Firebase. @hollyschinsky could you have a look? |
devgeeks
suggested changes
Nov 13, 2017
package.json
Outdated
| @@ -16,6 +16,9 @@ | |||
| "cordova-run": "npm run build && cordova run browser", | |||
| "cordova-run-ios": "npm run build && cordova run ios", | |||
| "cordova-run-android": "npm run build && cordova run android" | |||
| "deploy": "firebase deploy", | |||
There was a problem hiding this comment.
Missing a comma after the cordova-run-android script definition.
This was referenced Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…firebase config files