Skip to content
This repository has been archived by the owner on Apr 11, 2022. It is now read-only.

Invalid args can crash the app #306

Closed
purplecabbage opened this issue Apr 23, 2014 · 1 comment
Closed

Invalid args can crash the app #306

purplecabbage opened this issue Apr 23, 2014 · 1 comment
Assignees
@lorinbeer
Labels
bug
Milestone
April 28th - May 3rd

Comments

@purplecabbage
Copy link
Member

$ phonegap run local wp8 --verbose

c:\Users\KingShit\AppData\Roaming\npm\node_modules\phonegap\lib\phonegap\run.js:72
self.phonegap.emit('log', 'detecting', platform.human, 'SDK environment...

In this case I had run and local in the wrong order, which should output an error message, instead of throwing one.
@lorinbeer lorinbeer added this to the April 21st - April 25th milestone Apr 25, 2014
@lorinbeer lorinbeer self-assigned this Apr 25, 2014
@lorinbeer lorinbeer mentioned this issue Apr 30, 2014
Closed
lorinbeer pushed a commit that referenced this issue Apr 30, 2014
[#306] fixed crash on swapped parameter order with sanity check.
751f9b2 
placing sanity checks like this is a good way to bloat the code. See #308 for a plan to improve the error reporting system
@lorinbeer
Copy link
Contributor

fixed, commit in comments. See issue #308 for improving our error reporting so sanity checks don't need to be placed in every subcommand's implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lorinbeer lorinbeer

Labels
bug
Milestone
April 28th - May 3rd
Development

No branches or pull requests
2 participants
@purplecabbage @lorinbeer