Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Translation for errors #732

Closed
sjoerdloeve opened this issue Oct 29, 2018 · 3 comments
Closed

Translation for errors #732

sjoerdloeve opened this issue Oct 29, 2018 · 3 comments

Comments

@sjoerdloeve
Copy link

sjoerdloeve commented Oct 29, 2018

Expected Behaviour

Translated error message

Actual Behaviour

English error message

Reproduce Scenario (including but not limited to)

Set localization to FR, NL, anything but EN and reject camera access to your app

Steps to Reproduce

Go to the settings app, scroll down for your app and disable camera access. No open your app and click the scan button. You get an Engligh error message, no matter what localization you did provide in *.plist

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

iOS 12

Cordova CLI version and cordova platform version

8.0.0

Plugin version

8.0.0

Ps. the 'close' button is correct translated to the chosen language.

@jcesarmobile
Copy link
Collaborator

The error messages are NSLocalizedString, but we don't provide translations, just the english default value
If you want to translate it you have to create the strings files and translate yourself.

@sjoerdloeve
Copy link
Author

sjoerdloeve commented Oct 30, 2018

You are right about the text strings. But I can not find a possibility to translate the title "Scanning failed".

Nevermind: That one is in the JavaScript part configurable

@lock
Copy link

lock bot commented Nov 29, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants